New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewDevice - Hitachi Data Systems SAN #7160

Merged
merged 7 commits into from Aug 18, 2017

Conversation

Projects
None yet
3 participants
@EnzoZafra
Contributor

EnzoZafra commented Aug 15, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 17, 2017

Member

Looks good :)

Can you move the mib into a folder called hitachi, they are per vendor rather than per os.

Member

laf commented Aug 17, 2017

Looks good :)

Can you move the mib into a folder called hitachi, they are per vendor rather than per os.

@laf laf added the Blocker 🚫 label Aug 17, 2017

Show outdated Hide outdated includes/definitions/svos.yaml
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 17, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 17, 2017

The inspection completed: No new issues

@laf

laf approved these changes Aug 18, 2017

@laf laf merged commit 2da9ee7 into librenms:master Aug 18, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

neg2led added a commit to neg2led/librenms that referenced this pull request Aug 21, 2017

device: Added detection for Hitachi Data Systems SAN (#7160)
* Syslog test case

* revert changes on master

* newDevice: Hitachi Data Systems SAN

* Renamed mib directory

* Change discovery of sysObjectId
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.