New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Added script to generate config for new OS #7161

Merged
merged 2 commits into from Sep 4, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Aug 15, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Code is shite but for now, it's helping add new OS'


This change is Reviewable

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 15, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @f0o and @paulgear based on the history of these files to review this PR.

mention-bot commented Aug 15, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @f0o and @paulgear based on the history of these files to review this PR.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 15, 2017

The inspection completed: 1 new issues, 1 updated code elements

scrutinizer-notifier commented Aug 15, 2017

The inspection completed: 1 new issues, 1 updated code elements

@sfini

This comment has been minimized.

Show comment
Hide comment
@sfini

sfini Aug 25, 2017

Contributor

@laf
I'm working in support for radware/apsoluteos ( defense pro hw ).... If you want next week i can test the script with this os.

Simone

Contributor

sfini commented Aug 25, 2017

@laf
I'm working in support for radware/apsoluteos ( defense pro hw ).... If you want next week i can test the script with this os.

Simone

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 25, 2017

Member

@sfini Go for it :)

Member

laf commented Aug 25, 2017

@sfini Go for it :)

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 4, 2017

Member

Merging this in, I have a fair few new devices to add and this just simplifies things.

Member

laf commented Sep 4, 2017

Merging this in, I have a fair few new devices to add and this just simplifies things.

@laf laf merged commit edae335 into librenms:master Sep 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:feature/new-os-helper branch Sep 4, 2017

@sfini

This comment has been minimized.

Show comment
Hide comment
@sfini

sfini Sep 5, 2017

Contributor

@laf Tested for ApsoluteOs and it work very well...

Contributor

sfini commented Sep 5, 2017

@laf Tested for ApsoluteOs and it work very well...

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 5, 2017

Member

work very well...

very well is an overstatement but thanks for testing :)

Member

laf commented Sep 5, 2017

work very well...

very well is an overstatement but thanks for testing :)

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.