New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed dump_db_schema / validate to work with newer versions of MariaDB #7162

Merged
merged 2 commits into from Aug 17, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Aug 15, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes validate.php issues when running MariaDB 10.2.7 or later.

Removed two unused functions.

Tested on both MariaDB 10.2.7 and 5.5.50

@laf laf added the Bug 🐞 label Aug 15, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 15, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 15, 2017

The inspection completed: No new issues

@PdeNiet

This comment has been minimized.

Show comment
Hide comment
@PdeNiet

PdeNiet Aug 16, 2017

I tested it on MariaDB 10.2.7 as promised, works fine with this patch.
Thanks for looking into it Laf.

PdeNiet commented Aug 16, 2017

I tested it on MariaDB 10.2.7 as promised, works fine with this patch.
Thanks for looking into it Laf.

@laf laf merged commit ad6e82b into librenms:master Aug 17, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:fix/mariadb-10.2.7 branch Aug 17, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.