New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This change allows discovery/polling of all sensors (fans and tempera… #7183

Merged
merged 3 commits into from Aug 21, 2017

Conversation

Projects
None yet
5 participants
@netmax79
Contributor

netmax79 commented Aug 18, 2017

…tures) from Brocade VDX devices

instead of only the first few. This is tested with VDX 6740, 6740T, 8770-4, 8770-8.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

This change allows discovery/polling of all sensors (fans and tempera…
…tures) from Brocade VDX devices

instead of only the first few. This is tested with VDX 6740, 6740T, 8770-4, 8770-8.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 18, 2017

Thank you for submitting a PR @netmax79! We have found the following @laf based on the history of these files to review this PR.

mention-bot commented Aug 18, 2017

Thank you for submitting a PR @netmax79! We have found the following @laf based on the history of these files to review this PR.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Aug 18, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Aug 18, 2017

CLA assistant check
All committers have signed the CLA.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 19, 2017

Member

@netmax79 Does this leave the index value the same for existing sensors or is that changed?

Member

laf commented Aug 19, 2017

@netmax79 Does this leave the index value the same for existing sensors or is that changed?

@laf laf added the Blocker 🚫 label Aug 19, 2017

@netmax79

This comment has been minimized.

Show comment
Hide comment
@netmax79

netmax79 Aug 21, 2017

Contributor

Values of existing sensors are keept, new ones are added.

Contributor

netmax79 commented Aug 21, 2017

Values of existing sensors are keept, new ones are added.

laf added some commits Aug 21, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 21, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 21, 2017

The inspection completed: No new issues

@laf laf merged commit b132686 into librenms:master Aug 21, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.