New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Docs alerting #7185

Merged
merged 5 commits into from Aug 19, 2017

Conversation

Projects
None yet
6 participants
@benwa
Contributor

benwa commented Aug 19, 2017

Mostly tabelize the entities document for readability. Also cleanup some markdown

benwa added some commits Aug 19, 2017

Fix indenentation
YAML's pretty strict
Remove static anchor names
Markdown does this automatically for us
Remove tildes
They don't do anything
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 19, 2017

Thank you for submitting a PR @benwa! We have found the following @laf, @murrant and @florianbeer based on the history of these files to review this PR.

mention-bot commented Aug 19, 2017

Thank you for submitting a PR @benwa! We have found the following @laf, @murrant and @florianbeer based on the history of these files to review this PR.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Aug 19, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Aug 19, 2017

CLA assistant check
All committers have signed the CLA.

@benwa benwa changed the title from Docs alerting to docs: Docs alerting Aug 19, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 19, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 19, 2017

The inspection completed: No new issues

@laf laf merged commit 3199338 into librenms:master Aug 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@benwa benwa deleted the benwa:docs-alerting branch Aug 20, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Aug 20, 2017

Member

Super job @benwa :)

Member

murrant commented Aug 20, 2017

Super job @benwa :)

neg2led added a commit to neg2led/librenms that referenced this pull request Aug 21, 2017

docs: Updated alerting docs / formatting (#7185)
* Ignore docs/

* Fix indenentation

YAML's pretty strict

* Remove static anchor names

Markdown does this automatically for us

* Tabelize entities

* Remove tildes

They don't do anything
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.