New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: API #7187

Merged
merged 15 commits into from Aug 21, 2017

Conversation

Projects
None yet
4 participants
@benwa
Contributor

benwa commented Aug 19, 2017

Reformatted the table of contents to autogenerate.
Changed the output highlighting to json.

benwa added some commits Aug 19, 2017

Fix indenentation
YAML's pretty strict
Remove static anchor names
Markdown does this automatically for us
Remove tildes
They don't do anything
Switch output format
text -> json
Removed `top` links
Cause TOC generation problems.  A theme-wide `top` button would be more
appropriate
Use [TOC]
Automatically generates everything
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 19, 2017

Thank you for submitting a PR @benwa! We have found the following @laf, @murrant and @nerdalertdk based on the history of these files to review this PR.

mention-bot commented Aug 19, 2017

Thank you for submitting a PR @benwa! We have found the following @laf, @murrant and @nerdalertdk based on the history of these files to review this PR.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 19, 2017

Member

Thanks for this, the pull request contains a conflict from your other PR + it also includes all the other changes, can you update this one please.

Member

laf commented Aug 19, 2017

Thanks for this, the pull request contains a conflict from your other PR + it also includes all the other changes, can you update this one please.

@benwa

This comment has been minimized.

Show comment
Hide comment
@benwa

benwa Aug 20, 2017

Contributor

Aw crud, I'll try and fix this without making more of a mess

Contributor

benwa commented Aug 20, 2017

Aw crud, I'll try and fix this without making more of a mess

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 21, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 21, 2017

The inspection completed: No new issues

@laf laf merged commit f71c708 into librenms:master Aug 21, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 21, 2017

Member

image

Member

laf commented Aug 21, 2017

image

@benwa benwa deleted the benwa:docs-api branch Mar 7, 2018

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.