Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature: Notify about failed updates, block detectable bad updates #7188
Ability to post notifications when the update fails.
This will be used for removing in-tree dependencies and raising the minimum php version.
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
It will post one notification and remove it upon successful update. So, users are allowed to mark it as read. If the user marks it as read it won't show in their notification count, but it will still show a toast on page load.
Note that if users don't have updates enabled, they will not get a notification. (I also just pushed a change to have it remove any existing notifications in that case)
I'm unsure why travis hasn't picked this up:
That's after setting the sql mode to what we run in tests (I run that in my dev anyway)