New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add links for librenms graph #7193

Merged
merged 2 commits into from Aug 25, 2017

Conversation

Projects
None yet
4 participants
@yac01
Contributor

yac01 commented Aug 21, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@yac01

This comment has been minimized.

Show comment
Hide comment
@yac01

yac01 Aug 21, 2017

Contributor

@laf excuse me because This is the second time I have committed the same thing
i think i have problems in my count git ub because in each time when i make some modification in github i have the probleme that don't stop "ontinuous-integration/travis-ci/pr" but now I would not make any other changes on github i would do it only in the terminal

Contributor

yac01 commented Aug 21, 2017

@laf excuse me because This is the second time I have committed the same thing
i think i have problems in my count git ub because in each time when i make some modification in github i have the probleme that don't stop "ontinuous-integration/travis-ci/pr" but now I would not make any other changes on github i would do it only in the terminal

@laf

laf approved these changes Aug 21, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Aug 24, 2017

Member

The docs doesn't seem to mention $config['graphs']['mini']['widescreen'] and I'm not sure how the three fit together.

Member

murrant commented Aug 24, 2017

The docs doesn't seem to mention $config['graphs']['mini']['widescreen'] and I'm not sure how the three fit together.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 24, 2017

Member

$config['graphs']['mini']['widescreen'] = Widescreen setup for the pages like a direct port page.

$config['graphs']['mini']['normal'] = Normal screen size of the above.

$config['graphs']['row']['normal'] = The row of graphs you use to select the time period for a graph you want to see.

We can't use mini normal and row normal as this would change the number of graphs people see by default so this setup replicates the existing setup with the ability to custom either of those above scenarios.

Member

laf commented Aug 24, 2017

$config['graphs']['mini']['widescreen'] = Widescreen setup for the pages like a direct port page.

$config['graphs']['mini']['normal'] = Normal screen size of the above.

$config['graphs']['row']['normal'] = The row of graphs you use to select the time period for a graph you want to see.

We can't use mini normal and row normal as this would change the number of graphs people see by default so this setup replicates the existing setup with the ability to custom either of those above scenarios.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Aug 24, 2017

Member

Thanks @laf, we just need that in the docs and I think this is ready.

Member

murrant commented Aug 24, 2017

Thanks @laf, we just need that in the docs and I think this is ready.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 24, 2017

Member

@murrant doc update pushed.

Member

laf commented Aug 24, 2017

@murrant doc update pushed.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 24, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 24, 2017

The inspection completed: No new issues

@laf laf merged commit 38cf424 into librenms:master Aug 25, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.