New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White pages using PHP 7.1.x and Nginx 1.12.1 #7200

Merged
merged 1 commit into from Aug 21, 2017

Conversation

Projects
None yet
5 participants
@barry-smithjr
Contributor

barry-smithjr commented Aug 21, 2017

Set SCRIPT_FILENAME to prevent white pages on PHP 7.1.x

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Set SCRIPT_FILENAME
Set SCRIPT_FILENAME to prevent white pages on PHP 7.1.x
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 21, 2017

Thank you for submitting a PR @barry-smithjr! We have found the following @laf, @Gorian and @jodumont based on the history of these files to review this PR.

mention-bot commented Aug 21, 2017

Thank you for submitting a PR @barry-smithjr! We have found the following @laf, @Gorian and @jodumont based on the history of these files to review this PR.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Aug 21, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Aug 21, 2017

CLA assistant check
All committers have signed the CLA.

@barry-smithjr barry-smithjr changed the title from Set SCRIPT_FILENAME to White pages using PHP 7.1.x and Nginx 1.12.1 Aug 21, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 21, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 21, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 21, 2017

Member

Is this an Nginx 1.12.1 thing then? I've just yesterday done a new install which was ok:

[root@librenms01 ~]# nginx -v
nginx version: nginx/1.10.2
[root@librenms01 ~]# php -v
PHP 7.1.7 (cli) (built: Jul  6 2017 12:10:28) ( NTS )
Member

laf commented Aug 21, 2017

Is this an Nginx 1.12.1 thing then? I've just yesterday done a new install which was ok:

[root@librenms01 ~]# nginx -v
nginx version: nginx/1.10.2
[root@librenms01 ~]# php -v
PHP 7.1.7 (cli) (built: Jul  6 2017 12:10:28) ( NTS )
@barry-smithjr

This comment has been minimized.

Show comment
Hide comment
@barry-smithjr

barry-smithjr Aug 21, 2017

Contributor

I'm using Nginx from their official repo. Perhaps alternative sources such as EPEL have SCRIPT_FILENAME in the fastcgi_params already. My PHP is from IUS Community.

root@web01:/opt/librenms$ php -v && nginx -v PHP 7.1.7 (cli) (built: Jul 6 2017 14:17:16) ( NTS ) Copyright (c) 1997-2017 The PHP Group Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies with Zend OPcache v7.1.7, Copyright (c) 1999-2017, by Zend Technologies with Xdebug v2.5.5, Copyright (c) 2002-2017, by Derick Rethans nginx version: nginx/1.12.1

Contributor

barry-smithjr commented Aug 21, 2017

I'm using Nginx from their official repo. Perhaps alternative sources such as EPEL have SCRIPT_FILENAME in the fastcgi_params already. My PHP is from IUS Community.

root@web01:/opt/librenms$ php -v && nginx -v PHP 7.1.7 (cli) (built: Jul 6 2017 14:17:16) ( NTS ) Copyright (c) 1997-2017 The PHP Group Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies with Zend OPcache v7.1.7, Copyright (c) 1999-2017, by Zend Technologies with Xdebug v2.5.5, Copyright (c) 2002-2017, by Derick Rethans nginx version: nginx/1.12.1

@laf laf merged commit 6d6d8ce into librenms:master Aug 21, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 21, 2017

Member

Ace, thanks for the update :)

Member

laf commented Aug 21, 2017

Ace, thanks for the update :)

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.