New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Comware dBm Limits && Comware Sensor Descr #7216

Merged
merged 1 commit into from Aug 24, 2017

Conversation

Projects
None yet
5 participants
@Rosiak
Contributor

Rosiak commented Aug 23, 2017

  1. Make the interface sensors descriptions match the same "style" as Cisco.
  2. Do not detect interfaces which have not set hh3cTransceiverDiagnostic, this solves an issue where the MGMT interface on a device is wrongfully monitored.
  3. After yesterdays dBm thresholds update I discovered that we need to round off the values we insert into the DB, otherwise we end in a discovery loop where we will try to update the thresholds due to the discovered value is larger than what we can store in the DB, hence this will differ on each discovery.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 23, 2017

Thank you for submitting a PR @Rosiak! We have found the following @murrant, @laf and @crcro based on the history of these files to review this PR.

mention-bot commented Aug 23, 2017

Thank you for submitting a PR @Rosiak! We have found the following @murrant, @laf and @crcro based on the history of these files to review this PR.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 23, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 23, 2017

The inspection completed: No new issues

@kkrumm1

This comment has been minimized.

Show comment
Hide comment
@kkrumm1

kkrumm1 Aug 24, 2017

Member

This fixed my issues, I had the exact same problem. 👍

Member

kkrumm1 commented Aug 24, 2017

This fixed my issues, I had the exact same problem. 👍

@murrant murrant merged commit 701813f into librenms:master Aug 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.