New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Improve yaml state discovery #7221

Merged
merged 3 commits into from Sep 3, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Aug 24, 2017

Handle state values that are returned as strings instead of int
Synchronize state values for existing state translations so we can change them without creating a new translation and losing historical data
More extensive/verbose yaml discovery phpunit tests
dbBulkInsert, use the first entry instead of requiring the first entry to be at index 0

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


This change is Reviewable

feature: Improve yaml state discovery
Handle state values that are returned as strings instead of int
Synchronize state values for existing state translations so we can change them without creating a new translation and losing historical data
More extensive/verbose yaml discovery phpunit tests
dbBulkInsert, use the first entry instead of requiring the first entry to be at index 0

@murrant murrant referenced this pull request Aug 24, 2017

Closed

Rewrite broken netonix.inc.php #7189

1 of 1 task complete
Update sensor state documentation
re-order values for better readability
remove os check
Use snmpwalk_group since it is more flexible

@neg2led neg2led referenced this pull request Aug 25, 2017

Merged

Netonix PoE State Sensor Fix (YAML) #7224

1 of 1 task complete
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 28, 2017

The inspection completed: 4 updated code elements

scrutinizer-notifier commented Aug 28, 2017

The inspection completed: 4 updated code elements

@laf laf merged commit 7b262a6 into librenms:master Sep 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:improve-states-disco branch Sep 4, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.