Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
feature: Improve install process #7223
Fix incorrectly updating session with build-ok before start of schema update
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
Nice work @murrant :)
Install works as expected, trying to simulate a failure I restarted mysql during build-base, any schema updates attempted during the restart show an error and the whole process completes and thinks it's done still. Not sure if you'd expect that to happen or not?
@laf Try with
But If the database build gets interrupted, the results are unpredictable. I'm not sure how to handle that. I wanted to add transactions for this at one point so we don't get inconsistent databases. Perhaps it is time to revisit that?
-- Done 1 -bash-4.2$
That's repeatable - If the restart happens during:
-- Creating base database structure Step #0 ... Step #1 ... Step #2 ... Step #3 ... Step #4 ... Step #5 ... Step #6 ...
Then we get
If it happens after in:
-- Updating database schema 000 -> 001 ... done (0 errors). 001 -> 002 ... done (0 errors). 002 -> 003 ... done (2 errors). 003 -> 004 ... done (24 errors). 004 -> 005 ... done (11 errors). 005 -> 006 ... done (5 errors).
Does it not just need a