New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated dump_db_schema() to use default 0 if available #7225

Merged
merged 2 commits into from Aug 26, 2017

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Aug 26, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Better handling of 0 for default values, before these would have been replaced by NULL

@laf laf added the Bug 🐞 label Aug 26, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 26, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @zarya and @Rosiak based on the history of these files to review this PR.

mention-bot commented Aug 26, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @zarya and @Rosiak based on the history of these files to review this PR.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 26, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 26, 2017

The inspection completed: No new issues

@laf laf merged commit 932b05c into librenms:master Aug 26, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:fix/comm-945-193 branch Aug 26, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.