New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avtech sensor discovery #7244

Merged
merged 1 commit into from Aug 29, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Aug 28, 2017

$valid is no longer a global as it once was

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: avtech sensor discovery
$valid is no longer a global as it once was

@murrant murrant added the Bug 🐞 label Aug 28, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 28, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 28, 2017

The inspection completed: No new issues

@laf laf merged commit 21deb96 into librenms:master Aug 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

murrant added a commit that referenced this pull request Aug 31, 2017

fix: Fixed Avtech sensor discovery (#7244)
$valid is no longer a global as it once was

@murrant murrant deleted the murrant:fix-avtech-valid branch Sep 15, 2017

@steampoweredlawngnome

This comment has been minimized.

Show comment
Hide comment
@steampoweredlawngnome

steampoweredlawngnome Nov 6, 2017

It works great, thanks!

steampoweredlawngnome commented Nov 6, 2017

It works great, thanks!

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.