New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update notification for users with updates disabled #7253

Merged
merged 1 commit into from Aug 29, 2017

Conversation

Projects
None yet
2 participants
@murrant
Member

murrant commented Aug 29, 2017

Don't show the toast when the notification is marked as read

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: update notification for users with updates disabled
Don't show the toast when the notification is marked as read
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 29, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 29, 2017

The inspection completed: No new issues

@murrant murrant merged commit de8bcf3 into librenms:master Aug 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:fix-update-notif branch Aug 29, 2017

murrant added a commit that referenced this pull request Aug 31, 2017

fix: update notification for users with updates disabled (#7253)
Don't show the toast when the notification is marked as read
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.