New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reverted previous active directory changes #7254 #7257

Merged
merged 1 commit into from Aug 29, 2017

Conversation

Projects
None yet
2 participants
@laf
Member

laf commented Aug 29, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #7254
Reverts: #7175

@laf laf added the Bug 🐞 label Aug 29, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 29, 2017

The inspection completed: 1 updated code elements

scrutinizer-notifier commented Aug 29, 2017

The inspection completed: 1 updated code elements

@laf laf merged commit 4683736 into librenms:master Aug 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:fix/issue-7254 branch Aug 29, 2017

@NetworkNub NetworkNub referenced this pull request Aug 29, 2017

Closed

User not found in AD group #7254

5 of 5 tasks complete
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.