New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: AD support nested groups (resubmit #7175) #7259

Merged
merged 4 commits into from Oct 4, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Aug 30, 2017

NOTE: you may need to adjust your auth_ad_base_dn setting, see:
https://community.librenms.org/t/active-directory-base-dn/2247

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

feature: AD support nested groups (resubmit #7175)
Don't let groups with periods in the name cause issues.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 30, 2017

Thank you for submitting a PR @murrant! We have found the following @jonathon-k, @laf and @ekoyle based on the history of these files to review this PR.

mention-bot commented Aug 30, 2017

Thank you for submitting a PR @murrant! We have found the following @jonathon-k, @laf and @ekoyle based on the history of these files to review this PR.

@murrant murrant referenced this pull request Aug 30, 2017

Closed

User not found in AD group #7254

5 of 5 tasks complete

murrant added some commits Aug 31, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 31, 2017

The inspection completed: 1 new issues, 2 updated code elements

scrutinizer-notifier commented Aug 31, 2017

The inspection completed: 1 new issues, 2 updated code elements

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Sep 13, 2017

Member

As far as I can tell, this is ready.

  1. One user had periods in his group names, which caused them to be parsed incorrectly. This is fixed in this version.
  2. Another user had an issue where his groups were not in his base_dn, which should be the case but wasn't required by the previous code. I don't think this needs to be fixed in the code. We could create a notification to make sure users have a correct base_dn setting.
Member

murrant commented Sep 13, 2017

As far as I can tell, this is ready.

  1. One user had periods in his group names, which caused them to be parsed incorrectly. This is fixed in this version.
  2. Another user had an issue where his groups were not in his base_dn, which should be the case but wasn't required by the previous code. I don't think this needs to be fixed in the code. We could create a notification to make sure users have a correct base_dn setting.
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 13, 2017

Member

Another user had an issue where his groups were not in his base_dn, which should be the case but wasn't required by the previous code. I don't think this needs to be fixed in the code. We could create a notification to make sure users have a correct base_dn setting.

We should definitely at least document it somewhere, even if it's just a community post.

Member

laf commented Sep 13, 2017

Another user had an issue where his groups were not in his base_dn, which should be the case but wasn't required by the previous code. I don't think this needs to be fixed in the code. We could create a notification to make sure users have a correct base_dn setting.

We should definitely at least document it somewhere, even if it's just a community post.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 2, 2017

Member

from the docs:

$config['auth_ad_base_dn']                 = "<dc=your-domain,dc=com>";  // groups and users must be under this dn

Community announcement here: https://community.librenms.org/t/active-directory-base-dn/2247

Member

murrant commented Oct 2, 2017

from the docs:

$config['auth_ad_base_dn']                 = "<dc=your-domain,dc=com>";  // groups and users must be under this dn

Community announcement here: https://community.librenms.org/t/active-directory-base-dn/2247

@laf laf merged commit 503500f into librenms:master Oct 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:ad-nested-groups branch Oct 5, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.