New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for DragonWave Horizon #7264

Merged
merged 4 commits into from Aug 30, 2017

Conversation

Projects
None yet
5 participants
@pheinrichs
Copy link
Contributor

pheinrichs commented Aug 30, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Aug 30, 2017

CLA assistant check
All committers have signed the CLA.

@laf
Copy link
Member

laf left a comment

The OS logo needs to be 32x32 unless you use a SVG logo.

Few comments in line, should be good after that.

- { graph: device_wireless_power, text: 'Tx Power' }
discovery:
- sysObjectId:
- .1.3.6.1.4.1.7262.2.2

This comment has been minimized.

@laf

laf Aug 30, 2017

Member

Looks like you can change that to just 1.3.6.1.4.1.7262.2. to pick up more Horizon devices.

@@ -0,0 +1,10 @@
os: horizon

This comment has been minimized.

@laf

laf Aug 30, 2017

Member

Is this definitely the best os name? Is the firmware name?

This comment has been minimized.

@pheinrichs

pheinrichs Aug 30, 2017

Author Contributor

Horizon would be the best of name IMO.

* the source code distribution for details.
*/
$version = trim(snmp_get($device, ".1.3.6.1.4.1.7262.2.2.1.3.2.1.0", "-Ovq"), '" ');

This comment has been minimized.

@laf

laf Aug 30, 2017

Member

No mib available?

This comment has been minimized.

@pheinrichs

pheinrichs Aug 30, 2017

Author Contributor

I have yet to find an easy source of getting MIBS for dragonwave. I'll keep digging to see if I can get a source on them to add them.

pheinrichs and others added some commits Aug 30, 2017

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Aug 30, 2017

The inspection completed: 3 updated code elements

@laf laf merged commit 6914666 into librenms:master Aug 30, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@nosmowned

This comment has been minimized.

Copy link

nosmowned commented Sep 26, 2017

Dragonwave Harmony Enhanced MC

DW_HAR_MC_MIB.zip

@pheinrichs pheinrichs deleted the pheinrichs:dragonwave-support branch Oct 18, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.