New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated graph_types table so graph_subtype has no default value #7285

Merged
merged 2 commits into from Sep 5, 2017

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Sep 4, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

This should fix the validate issues. We insert a value into this column so it makes sense to just have it set as NOT NULL with no default value.


This change is Reviewable

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Sep 4, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Sep 4, 2017

The inspection completed: No new issues

@laf laf added the Schema label Sep 4, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Sep 5, 2017

Member

Thanks @laf, been meaning to get this fixed. I wasn't sure the schema update was needed, but when I tested it, it was.

Member

murrant commented Sep 5, 2017

Thanks @laf, been meaning to get this fixed. I wasn't sure the schema update was needed, but when I tested it, it was.

@murrant murrant merged commit c16ca70 into librenms:master Sep 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.