New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: add support for Mimosa A5 #7287

Merged
merged 3 commits into from Sep 7, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented Sep 5, 2017

Unfortunately, we would have to walk the client table to get any client stats such as count.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fixes: #7267


This change is Reviewable

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Sep 5, 2017

Thank you for submitting a PR @murrant! We have found the following @laf based on the history of these files to review this PR.

mention-bot commented Sep 5, 2017

Thank you for submitting a PR @murrant! We have found the following @laf based on the history of these files to review this PR.

device: add support for Mimosa A5
Frequency and Tx/Rx Power

Unfortunately, we would have to walk the client table to get any client stats such as count.

@murrant murrant changed the title from device: add support for Mimosa A5 to newdevice: add support for Mimosa A5 Sep 5, 2017

murrant added some commits Sep 5, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier commented Sep 7, 2017

A new inspection was created.

@laf laf merged commit 66f9411 into librenms:master Sep 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:mimosa-mtmp branch Sep 7, 2017

@rbax82

This comment has been minimized.

Show comment
Hide comment
@rbax82

rbax82 Sep 21, 2017

Contributor

FYI; this template is causing my A5 to reboot after a number of polls.

Contributor

rbax82 commented Sep 21, 2017

FYI; this template is causing my A5 to reboot after a number of polls.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 21, 2017

Member

If the polls complete initially then it sounds just like a poor snmp implementation. I'd suggest disabling some modules to lower the load.

Member

laf commented Sep 21, 2017

If the polls complete initially then it sounds just like a poor snmp implementation. I'd suggest disabling some modules to lower the load.

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.