New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Added support for Saf Integra Access points #7292

Merged
merged 5 commits into from Sep 8, 2017

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Sep 5, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #7248
Fixes: #7249

image


This change is Reviewable

@laf laf added the Device 🖥 label Sep 5, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 5, 2017

Member

This includes two OS'.

I did originally have them in one but it seemed silly, the code is sort of duplicated but each has it's own MIB and oids so separate seems sensible.

Member

laf commented Sep 5, 2017

This includes two OS'.

I did originally have them in one but it seemed silly, the code is sort of duplicated but each has it's own MIB and oids so separate seems sensible.

laf added some commits Sep 8, 2017

@murrant

murrant approved these changes Sep 8, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Sep 8, 2017

The inspection completed: 3 new issues, 12 updated code elements

scrutinizer-notifier commented Sep 8, 2017

The inspection completed: 3 new issues, 12 updated code elements

@murrant murrant merged commit 455c721 into librenms:master Sep 8, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.