New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Added detection for Himoinsa Gensets #7295

Merged
merged 2 commits into from Sep 10, 2017

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Sep 6, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #6964


This change is Reviewable

@laf laf added the Device 🖥 label Sep 6, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Sep 6, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Sep 6, 2017

The inspection completed: No new issues

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Sep 8, 2017

Member

@laf can you minimize the svg file? for some reason I cannot edit this pr.

Member

murrant commented Sep 8, 2017

@laf can you minimize the svg file? for some reason I cannot edit this pr.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 9, 2017

Member

@murrant Done. The option to allow edits from maintainers wasn't ticked, I wonder if it's now off by default.

Member

laf commented Sep 9, 2017

@murrant Done. The option to allow edits from maintainers wasn't ticked, I wonder if it's now off by default.

@murrant murrant merged commit 9cafcb6 into librenms:master Sep 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:device/issue-6964 branch Sep 10, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.