New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OS discovery for ServerChecks #7308

Merged
merged 13 commits into from Sep 10, 2017

Conversation

Projects
None yet
4 participants
@jayceeemperador
Contributor

jayceeemperador commented Sep 9, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

It's my first time doing this. Created the yaml file for the Serverscheck device and also logo


This change is Reviewable

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Sep 9, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Sep 9, 2017

CLA assistant check
All committers have signed the CLA.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 9, 2017

Member

Monitoring the monitors eh :)

Thanks for the PR, few issues that need to be fixed though first:

Member

laf commented Sep 9, 2017

Monitoring the monitors eh :)

Thanks for the PR, few issues that need to be fixed though first:

jayceeemperador added some commits Sep 10, 2017

Add OS discovery for ServerChecks #7308
Added mib directory for serverscheck
Add OS discovery for ServerChecks #7308
Added snmprec file for serverscheck
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Sep 10, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Sep 10, 2017

The inspection completed: No new issues

@laf laf merged commit dbbb9ca into librenms:master Sep 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 10, 2017

Member

image

Member

laf commented Sep 10, 2017

image

@laf laf referenced this pull request Sep 10, 2017

Closed

Add OS discovery for ServerChecks #7284

5 of 5 tasks complete
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.