New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Added support for Toshiba RemotEye4 devices #7312

Merged
merged 4 commits into from Sep 13, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Sep 9, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #7258


This change is Reviewable

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Sep 9, 2017

Thank you for submitting a PR @laf! We have found the following @crcro, @murrant and @geordish based on the history of these files to review this PR.

mention-bot commented Sep 9, 2017

Thank you for submitting a PR @laf! We have found the following @crcro, @murrant and @geordish based on the history of these files to review this PR.

@kate66

This comment has been minimized.

Show comment
Hide comment
@kate66

kate66 Sep 9, 2017

Contributor

I have deployed this and so far it looks great. The values match the webgui for the RemoteEye itself.
EDIT: The battery charge may be incorrect, it currently shows 0%.

Contributor

kate66 commented Sep 9, 2017

I have deployed this and so far it looks great. The values match the webgui for the RemoteEye itself.
EDIT: The battery charge may be incorrect, it currently shows 0%.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 10, 2017

Member

That's all your device reported for batter :(

Member

laf commented Sep 10, 2017

That's all your device reported for batter :(

laf added some commits Sep 10, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Sep 10, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Sep 10, 2017

The inspection completed: No new issues

@kate66

This comment has been minimized.

Show comment
Hide comment
@kate66

kate66 Sep 13, 2017

Contributor

This is still good, please merge!

Contributor

kate66 commented Sep 13, 2017

This is still good, please merge!

@murrant murrant merged commit e0040b2 into librenms:master Sep 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Sep 13, 2017

Member

@laf I'm assuming you decided to walk individual oids instead of upsInput and upsOutput? Or just happened to write it that way?

Member

murrant commented Sep 13, 2017

@laf I'm assuming you decided to walk individual oids instead of upsInput and upsOutput? Or just happened to write it that way?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 13, 2017

Member

@murrant upsInput and Output aren't tables so I default to using the individual values.

Member

laf commented Sep 13, 2017

@murrant upsInput and Output aren't tables so I default to using the individual values.

@laf laf deleted the laf:newdevice/issue-7258 branch Sep 13, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.