New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Added additional Quanta detection #7316

Merged
merged 1 commit into from Sep 13, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Sep 10, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #7311


This change is Reviewable

@laf laf added the Device 🖥 label Sep 10, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Sep 10, 2017

Thank you for submitting a PR @laf! We have found the following @segfault based on the history of these files to review this PR.

mention-bot commented Sep 10, 2017

Thank you for submitting a PR @laf! We have found the following @segfault based on the history of these files to review this PR.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Sep 10, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Sep 10, 2017

The inspection completed: No new issues

@f0o

This comment has been minimized.

Show comment
Hide comment
@f0o

f0o Sep 11, 2017

Member

:lgtm:


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Member

f0o commented Sep 11, 2017

:lgtm:


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@murrant murrant merged commit 58193e1 into librenms:master Sep 13, 2017

3 checks passed

code-review/reviewable 3 files reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:newdevice/issue-7311 branch Sep 13, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.