New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DHCP Leases Graph for Mikrotik #7333

Merged
merged 1 commit into from Sep 13, 2017

Conversation

Projects
None yet
4 participants
@pheinrichs
Contributor

pheinrichs commented Sep 13, 2017

Added basic graph for DHCP leases for mikrotik.

I didn't see an option to add this via the yaml, if there is let me know and I can refactor.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


This change is Reviewable

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Sep 13, 2017

Thank you for submitting a PR @pheinrichs! We have found the following @laf, @adaniels21487 and @barryodonovan based on the history of these files to review this PR.

mention-bot commented Sep 13, 2017

Thank you for submitting a PR @pheinrichs! We have found the following @laf, @adaniels21487 and @barryodonovan based on the history of these files to review this PR.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Sep 13, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Sep 13, 2017

The inspection completed: No new issues

@laf laf merged commit 9f553af into librenms:master Sep 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@pheinrichs pheinrichs deleted the pheinrichs:add-dhcpleasecount-mikrotik branch May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment