New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: Show how long a device has been down if it is down #7336

Merged
merged 1 commit into from Sep 29, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Sep 13, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

I've only done it on the overview page as I felt showing it in the device list will be confusing as the column is titled uptime.

https://community.librenms.org/t/down-devices-shows-up-time/2073


This change is Reviewable

@laf laf added the WebUI label Sep 13, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Sep 13, 2017

Thank you for submitting a PR @laf! We have found the following @f0o, @InsaneSplash and @murrant based on the history of these files to review this PR.

mention-bot commented Sep 13, 2017

Thank you for submitting a PR @laf! We have found the following @f0o, @InsaneSplash and @murrant based on the history of these files to review this PR.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Sep 13, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Sep 13, 2017

The inspection completed: No new issues

@@ -16,7 +16,13 @@
echo '</div>
<table class="table table-hover table-condensed table-striped">';
$uptime = $device['uptime'];
$uptime = formatUptime($device['uptime']);

This comment has been minimized.

@murrant

murrant Sep 13, 2017

Member

Minor, but shouldn't this be in an else?

@murrant

murrant Sep 13, 2017

Member

Minor, but shouldn't this be in an else?

This comment has been minimized.

@laf

laf Sep 14, 2017

Member

Doesn't need to be. We set it to what it was before and overwrite it if the device is down using another value.

@laf

laf Sep 14, 2017

Member

Doesn't need to be. We set it to what it was before and overwrite it if the device is down using another value.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf
Member

laf commented Sep 27, 2017

@kkrumm1

This comment has been minimized.

Show comment
Hide comment
@kkrumm1

kkrumm1 Sep 27, 2017

Member

seems legit laf.
image

Member

kkrumm1 commented Sep 27, 2017

seems legit laf.
image

@laf laf merged commit 30318b7 into librenms:master Sep 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.