New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rfc1628 runtime - allow os quirks #7340

Merged
merged 1 commit into from Sep 14, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Sep 14, 2017

Also, properly divide values at discovery
Remove accidental debug output

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

#7331


This change is Reviewable

fix: rfc1628 runtime - allow os quirks
Also, properly divide values at discovery
Remove accidental debug output
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Sep 14, 2017

The inspection completed: 1 updated code elements

scrutinizer-notifier commented Sep 14, 2017

The inspection completed: 1 updated code elements

@murrant murrant added the Bug 🐞 label Sep 14, 2017

@murrant murrant referenced this pull request Sep 14, 2017

Closed

RouterOS support for monitoring a USB connected UPS #7331

0 of 1 task complete
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 14, 2017

Member

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Member

laf commented Sep 14, 2017

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@laf laf merged commit b4d804f into librenms:master Sep 14, 2017

3 checks passed

code-review/reviewable 3 files reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:fix-rfc1628-runtime-quirks branch Sep 14, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.