New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rfc1628 tidy up #7341

Merged
merged 4 commits into from Sep 19, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Sep 14, 2017

Make things more readable
reduce the amount of snmp calls

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


This change is Reviewable

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Sep 14, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @FTBZ and @crcro based on the history of these files to review this PR.

mention-bot commented Sep 14, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @FTBZ and @crcro based on the history of these files to review this PR.

'charge',
$device,
'.1.3.6.1.2.1.33.1.2.4.0',
500,

This comment has been minimized.

@laf

laf Sep 14, 2017

Member

This will lose people historical data as the old index was 500 + $index.

@laf

laf Sep 14, 2017

Member

This will lose people historical data as the old index was 500 + $index.

This comment has been minimized.

@murrant

murrant Sep 14, 2017

Member

Nope, the only valid index is 0. This is not a table, just a single oid.

@murrant

murrant Sep 14, 2017

Member

Nope, the only valid index is 0. This is not a table, just a single oid.

'current',
$device,
$oid,
500,

This comment has been minimized.

@laf

laf Sep 14, 2017

Member

Same here.

@laf

laf Sep 14, 2017

Member

Same here.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Sep 15, 2017

Member

I updated the rfc1628 load discovery, but have not tested it yet. I will do later when I'm on my other computer.

Member

murrant commented Sep 15, 2017

I updated the rfc1628 load discovery, but have not tested it yet. I will do later when I'm on my other computer.

murrant added some commits Sep 14, 2017

refactor: rfc1628 tidy up
reduce the amount of snmp calls
@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Sep 16, 2017

Member

Went back and forth between master and this with three different ups models (tripplite, powerwalker, and eaton)

Only two differences:
power: bypass had wrong oid fixed
current: the old code was incorrectly adding a couple of sensors even when they didn't exist. So, the new code fixed one bug :D

Member

murrant commented Sep 16, 2017

Went back and forth between master and this with three different ups models (tripplite, powerwalker, and eaton)

Only two differences:
power: bypass had wrong oid fixed
current: the old code was incorrectly adding a couple of sensors even when they didn't exist. So, the new code fixed one bug :D

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 16, 2017

Member

Using snmpsimd, I'm seeing some duplicates:

Powerwalker:

image

image

image

image

Eaton:

image

image

image

I can provide the snmprec files if you need.

Member

laf commented Sep 16, 2017

Using snmpsimd, I'm seeing some duplicates:

Powerwalker:

image

image

image

image

Eaton:

image

image

image

I can provide the snmprec files if you need.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Sep 19, 2017

Member

Crap, I accidentally included my testing changes to the yaml files. Eatonups and powerwalker don't actually use rfc1628 but they provide data, so I used them to test.

Member

murrant commented Sep 19, 2017

Crap, I accidentally included my testing changes to the yaml files. Eatonups and powerwalker don't actually use rfc1628 but they provide data, so I used them to test.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Sep 19, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Sep 19, 2017

The inspection completed: No new issues

@laf laf merged commit 39804b0 into librenms:master Sep 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:refactor-rfc1628 branch Sep 21, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.