New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Added detection of vlan name changes #7348

Merged
merged 1 commit into from Sep 17, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Sep 15, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #7247

It could do with a refactor in general but this is all I've got time for right now :(


This change is Reviewable

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Sep 15, 2017

Thank you for submitting a PR @laf! We have found the following @ekoyle, @tslytsly and @murrant based on the history of these files to review this PR.

mention-bot commented Sep 15, 2017

Thank you for submitting a PR @laf! We have found the following @ekoyle, @tslytsly and @murrant based on the history of these files to review this PR.

@laf laf referenced this pull request Sep 15, 2017

Closed

Vlan's don't get updated #7247

3 of 5 tasks complete
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Sep 15, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Sep 15, 2017

The inspection completed: No new issues

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Sep 15, 2017

Member

I'd label this as feature and a bugfix :)

Member

murrant commented Sep 15, 2017

I'd label this as feature and a bugfix :)

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 16, 2017

Member

lol, feature maybe but as it was never added I wouldn't go as far to say bug :p

Member

laf commented Sep 16, 2017

lol, feature maybe but as it was never added I wouldn't go as far to say bug :p

@murrant murrant merged commit 4ad8fae into librenms:master Sep 17, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

laf added a commit that referenced this pull request Sep 17, 2017

laf added a commit that referenced this pull request Sep 17, 2017

Revert "refactor: rewrite is_valid_port()" (#7355)
* Revert "refactor: Added detection of vlan name changes (#7348)"

This reverts commit 4ad8fae.

* Revert "refactor: Rewrite is_valid_port() (#7337)"

This reverts commit 3160741.

@laf laf deleted the laf:refactor/issue-7247 branch Sep 17, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.