Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated docs to include installing xml php modules + updated validate #7349

Merged
merged 1 commit into from Sep 16, 2017

Conversation

laf
Copy link
Member

@laf laf commented Sep 15, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Changed the == false check because === didn't work (tested by doing xmll). This is needed for notifications support.


This change is Reviewable

@mention-bot
Copy link

Thank you for submitting a PR @laf! We have found the following @Gorian, @kedearian and @murrant based on the history of these files to review this PR.

@scrutinizer-notifier
Copy link

The inspection completed: 1 new issues

@murrant murrant merged commit 529660b into librenms:master Sep 16, 2017
@laf laf deleted the docs/xml branch September 16, 2017 08:28
@lock
Copy link

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants