Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
api: Added ability to supports CORS for API #7357
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
Docs done, disabled by default.
We do need to be careful with php 5.3. A commit removes it from travis checks. Composer doesn't indicate a required version.
Edit, actually, looks ok:
sh-4.1# php -v PHP 5.3.3 (cli) (built: Mar 22 2017 12:27:09) Copyright (c) 1997-2010 The PHP Group Zend Engine v2.3.0, Copyright (c) 1998-2010 Zend Technologies sh-4.1# ./vendor/bin/parallel-lint --exclude lib/influxdb-php/ ./vendor/palanik/ PHP 5.3.3 | 10 parallel jobs .... 4/4 (100 %) Checked 4 files in 0 seconds No syntax error found
XMLHttpRequest cannot load https://librenms.nsa.his.se/api/v0/services/xxx.xxxx.xxx.xxx. Request header field X-Auth-Token is not allowed by Access-Control-Allow-Headers in preflight response.
Include X-Auth-Token in the default example, might be good idee ?
Reviewed 27 of 28 files at r1, 1 of 1 files at r2.
X-Auth-Token ought to be added here
Comments from Reviewable