New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: Updated alert rule collection to be table #7371

Merged
merged 1 commit into from Sep 29, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Sep 20, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

image

Seems better suited than just an input box.


This change is Reviewable

@laf laf added the WebUI label Sep 20, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Sep 20, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Sep 20, 2017

The inspection completed: No new issues

@kkrumm1

This comment has been minimized.

Show comment
Hide comment
@kkrumm1

kkrumm1 Sep 27, 2017

Member

did a test pull on this it works! 👍 :D

Member

kkrumm1 commented Sep 27, 2017

did a test pull on this it works! 👍 :D

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 27, 2017

Member

Thanks @kkrumm1 - anyone else? @librenms/reviewers

Member

laf commented Sep 27, 2017

Thanks @kkrumm1 - anyone else? @librenms/reviewers

@geordish

This comment has been minimized.

Show comment
Hide comment
@geordish

geordish Sep 28, 2017

Contributor

Looks better, but maybe hold on till the DataTables stuff is complete/merged?

Failing that it's another thing for me to update!

Contributor

geordish commented Sep 28, 2017

Looks better, but maybe hold on till the DataTables stuff is complete/merged?

Failing that it's another thing for me to update!

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 28, 2017

Member

It's a simple on this, just applying datatables to the table rather than doing ajax/backend processing - I'll update it once your PR is more complete so don't worry

Member

laf commented Sep 28, 2017

It's a simple on this, just applying datatables to the table rather than doing ajax/backend processing - I'll update it once your PR is more complete so don't worry

@laf laf merged commit 98e509c into librenms:master Sep 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:webui/rule-collection branch Sep 29, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.