New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Added sensor detection for APC In Row RD devices #7385

Merged
merged 5 commits into from Sep 29, 2017

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Sep 24, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #7319

Adds pressure (kPa) and cooling (W)

image


This change is Reviewable

@laf laf added the Device 🖥 label Sep 24, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Sep 24, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @HenocKA and @FTBZ based on the history of these files to review this PR.

mention-bot commented Sep 24, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @HenocKA and @FTBZ based on the history of these files to review this PR.

laf added some commits Sep 25, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Sep 25, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Sep 25, 2017

The inspection completed: No new issues

@laf laf merged commit 592e8ac into librenms:master Sep 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:newdevice/issue-7319 branch Sep 29, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.