New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for alternate Equallogic SNMP sysObjectId #7394

Merged
merged 5 commits into from Oct 5, 2017

Conversation

Projects
None yet
4 participants
@FrankPetrilli
Contributor

FrankPetrilli commented Sep 27, 2017

My Equallogic PS100E-series array is discovered as "generic" and therefore doesn't have any of the Equallogic-specific changes.

Its sysObjectId is .1.3.6.1.4.1.12740.12.1.1.0, so adding this to the device definition has allowed me to monitor all available features.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


This change is Reviewable

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Sep 27, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Sep 27, 2017

CLA assistant check
All committers have signed the CLA.

@laf

I've made a comment to the yaml file.

Can you also please add a unit test: https://docs.librenms.org/Developing/os/Test-Units/

Show outdated Hide outdated includes/definitions/equallogic.yaml

@laf laf added the Device 🖥 label Sep 27, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 28, 2017

Member

Thanks for updating, you've included some other files in this pull request now though. Can you clean those up and put them back to how they were?

Member

laf commented Sep 28, 2017

Thanks for updating, you've included some other files in this pull request now though. Can you clean those up and put them back to how they were?

@FrankPetrilli

This comment has been minimized.

Show comment
Hide comment
@FrankPetrilli

FrankPetrilli Sep 29, 2017

Contributor

Yep, that's what I get for committing before coffee. -.- Submitted changes.

Contributor

FrankPetrilli commented Sep 29, 2017

Yep, that's what I get for committing before coffee. -.- Submitted changes.

@laf

@FrankPetrilli if you can respond to that comment that would be ace. We need the genuine sysDescr in the test unit (masked data is fine).

Show outdated Hide outdated tests/snmpsim/equallogic_1.snmprec
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 5, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Oct 5, 2017

The inspection completed: No new issues

@laf

laf approved these changes Oct 5, 2017

@laf laf merged commit b89ed26 into librenms:master Oct 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.