New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Basic hanwha techwin support #7397

Merged
merged 5 commits into from Oct 1, 2017

Conversation

Projects
None yet
3 participants
@aldemira
Contributor

aldemira commented Sep 28, 2017

Also known as Samsung iPolis Cameras

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


This change is Reviewable

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 28, 2017

Member

Using the vendor name usually isn't a good OS name. Is iPOLiS not better?

Member

laf commented Sep 28, 2017

Using the vendor name usually isn't a good OS name. Is iPOLiS not better?

@aldemira

This comment has been minimized.

Show comment
Hide comment
@aldemira

aldemira Sep 29, 2017

Contributor

Of course, I didn't know what to write there since it's basically a branded linux.

Contributor

aldemira commented Sep 29, 2017

Of course, I didn't know what to write there since it's basically a branded linux.

@laf

@aldemira just this one last thing - would love to get this merged before sunday for release day if you can take a look?

Show outdated Hide outdated includes/definitions/ipolis.yaml
Show outdated Hide outdated tests/snmpsim/ipolis.snmprec
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Sep 30, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Sep 30, 2017

The inspection completed: No new issues

@laf laf merged commit b4af919 into librenms:master Oct 1, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@aldemira aldemira deleted the aldemira:hanwhatechwin branch Dec 19, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.