New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: more zywall-usg support #7405

Merged
merged 4 commits into from Oct 3, 2017

Conversation

Projects
None yet
4 participants
@tomarch
Contributor

tomarch commented Sep 29, 2017

Need for new USG device (USG20, USG20W, USG40, USG110, ...)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


This change is Reviewable

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 29, 2017

Member

Thanks @tomarch. Can you add the required unit test please: https://docs.librenms.org/Developing/os/Test-Units/

Preferably one for each of the new devices you are adding support for.

Member

laf commented Sep 29, 2017

Thanks @tomarch. Can you add the required unit test please: https://docs.librenms.org/Developing/os/Test-Units/

Preferably one for each of the new devices you are adding support for.

@laf laf added the Device 🖥 label Sep 29, 2017

@tomarch

This comment has been minimized.

Show comment
Hide comment
@tomarch

tomarch Sep 30, 2017

Contributor

Sure i can.
There's one zywall_1.snmprec for USG300 and one zywall_2.snmprec for USG60
Do i continue with this syntax (zywall_3.snmprec for USG110, etc...) or may i have to rename it (like zywall_usg110.snmprec) ?

Contributor

tomarch commented Sep 30, 2017

Sure i can.
There's one zywall_1.snmprec for USG300 and one zywall_2.snmprec for USG60
Do i continue with this syntax (zywall_3.snmprec for USG110, etc...) or may i have to rename it (like zywall_usg110.snmprec) ?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 1, 2017

Member

You can use _usg110 and variations of models, that's fine.

Member

laf commented Oct 1, 2017

You can use _usg110 and variations of models, that's fine.

tomarch added some commits Sep 29, 2017

device: more zywall-usg support
move and add snmpsim files
@tomarch

This comment has been minimized.

Show comment
Hide comment
@tomarch

tomarch Oct 2, 2017

Contributor

I add the files (excuse me for the multiple commit, i'm a git noob).

Contributor

tomarch commented Oct 2, 2017

I add the files (excuse me for the multiple commit, i'm a git noob).

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 2, 2017

Member

Thanks for the updates @tomarch this was written before we had exclusions, can you update it to:

discovery:
    -
      sysObjectId:
          - .1.3.6.1.4.1.890.1.6
          - .1.3.6.1.4.1.890.1.15
      sysDescr_regex_except:
          - '/^NWA/'

That should be a better fix :)

Member

murrant commented Oct 2, 2017

Thanks for the updates @tomarch this was written before we had exclusions, can you update it to:

discovery:
    -
      sysObjectId:
          - .1.3.6.1.4.1.890.1.6
          - .1.3.6.1.4.1.890.1.15
      sysDescr_regex_except:
          - '/^NWA/'

That should be a better fix :)

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 2, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Oct 2, 2017

The inspection completed: No new issues

@laf laf merged commit a1d7826 into librenms:master Oct 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.