New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features: Add alert rules for RFC1628 UPS to the collection #7415

Merged
merged 1 commit into from Oct 3, 2017

Conversation

Projects
None yet
3 participants
@FTBZ
Contributor

FTBZ commented Oct 2, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


  • Added some rules for RFC 1628 UPS, tested on APC Galaxy and Generex SNMP card
  • Corrected some indentation

This change is Reviewable

Show outdated Hide outdated misc/alert_rules.json Outdated
Show outdated Hide outdated misc/alert_rules.json Outdated
@FTBZ

This comment has been minimized.

Show comment
Hide comment
@FTBZ

FTBZ Oct 3, 2017

Contributor

Thanks, done.

Contributor

FTBZ commented Oct 3, 2017

Thanks, done.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 3, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Oct 3, 2017

The inspection completed: No new issues

@laf laf merged commit e169004 into librenms:master Oct 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 3, 2017

Member

Thanks @FTBZ

Member

laf commented Oct 3, 2017

Thanks @FTBZ

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.