New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rfc1628 state sensor translations #7416

Merged
merged 1 commit into from Oct 2, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented Oct 2, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


This change is Reviewable

@murrant murrant added the Bug 🐞 label Oct 2, 2017

@f0o

This comment has been minimized.

Show comment
Hide comment
@f0o

f0o Oct 2, 2017

Member

Still getting used to this reviewable thing

Member

f0o commented Oct 2, 2017

Still getting used to this reviewable thing

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 2, 2017

Member

no worries, I've barely looked at it ;-)

Member

murrant commented Oct 2, 2017

no worries, I've barely looked at it ;-)

@f0o

This comment has been minimized.

Show comment
Hide comment
@f0o

f0o Oct 2, 2017

Member

LGTM


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Member

f0o commented Oct 2, 2017

LGTM


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 2, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Oct 2, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 2, 2017

Member

Ignore reviewable. I got recommended it but thought it was just a me thing. I'll remove it.

Member

laf commented Oct 2, 2017

Ignore reviewable. I got recommended it but thought it was just a me thing. I'll remove it.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 2, 2017

Member

@laf it doesn't bother me, I just haven't had the time to give it a look. If it is useful, keep using it.

Member

murrant commented Oct 2, 2017

@laf it doesn't bother me, I just haven't had the time to give it a look. If it is useful, keep using it.

@FTBZ

This comment has been minimized.

Show comment
Hide comment
@FTBZ

FTBZ Oct 2, 2017

Contributor

I think it's working, tested on Generex and APC/MGE.

Contributor

FTBZ commented Oct 2, 2017

I think it's working, tested on Generex and APC/MGE.

@f0o f0o merged commit 738067e into librenms:master Oct 2, 2017

3 checks passed

code-review/reviewable 1 file reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:rfc1628-stateindex branch Oct 13, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.