New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: technicolor TG650S and TG670S #7420

Merged
merged 7 commits into from Oct 4, 2017

Conversation

Projects
None yet
3 participants
@tomarch
Contributor

tomarch commented Oct 3, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


This change is Reviewable

@laf

Unless you use an svg logo you will need to set the dimensions of the png to 32x32.

Show outdated Hide outdated tests/snmpsim/technicolor_tg650s.snmprec
Show outdated Hide outdated includes/polling/os/technicolor.inc.php
Show outdated Hide outdated includes/definitions/technicolor.yaml
Show outdated Hide outdated includes/definitions/technicolor.yaml

@laf laf added the Blocker 🚫 label Oct 3, 2017

tomarch added some commits Oct 3, 2017

@laf

So very close :)

Show outdated Hide outdated html/images/os/technicolor.svg
Show outdated Hide outdated includes/definitions/tgos.yaml

tomarch added some commits Oct 4, 2017

@laf

laf approved these changes Oct 4, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 4, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Oct 4, 2017

The inspection completed: No new issues

@laf laf merged commit 931bfce into librenms:master Oct 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 4, 2017

Member

Thanks again :D

Member

laf commented Oct 4, 2017

Thanks again :D

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.