New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Brocade IronWare interface dBm sensor support #7434

Merged
merged 5 commits into from Oct 17, 2017

Conversation

Projects
None yet
3 participants
@thecityofguanyu
Contributor

thecityofguanyu commented Oct 5, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 15, 2017

Member

I've made some tweaks. Can you pull those changes in and see if it still works for you?

Member

laf commented Oct 15, 2017

I've made some tweaks. Can you pull those changes in and see if it still works for you?

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 15, 2017

The inspection completed: 1 updated code elements

scrutinizer-notifier commented Oct 15, 2017

The inspection completed: 1 updated code elements

@thecityofguanyu

This comment has been minimized.

Show comment
Hide comment
@thecityofguanyu

thecityofguanyu Oct 17, 2017

Contributor

Looks like it still works. Appreciate the fixes!

Contributor

thecityofguanyu commented Oct 17, 2017

Looks like it still works. Appreciate the fixes!

@laf laf merged commit 04bb65b into librenms:master Oct 17, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@thecityofguanyu thecityofguanyu deleted the thecityofguanyu:ironware-iface-dbm-sensor branch Nov 11, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.