New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve accuracy of is_valid_hostname() #7435

Merged
merged 2 commits into from Oct 5, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Oct 5, 2017

fixes discovery code attempting to add invalid dns names
the old code allowed some invalid hostnames, this is more thorough
add tests

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 5, 2017

Member

@kkrumm1 please test this

Member

murrant commented Oct 5, 2017

@kkrumm1 please test this

murrant added some commits Oct 5, 2017

fix: improve accuracy of is_valid_hostname()
fixes discovery code attempting to add discover invalid dns names
the old code allowed some invalid hostnames, this is more thorough
add tests
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier commented Oct 5, 2017

A new inspection was created.

@kkrumm1

This comment has been minimized.

Show comment
Hide comment
@kkrumm1

kkrumm1 Oct 5, 2017

Member

testing meow...

@murrant what do you want to report back the discovery protocols debug?

Member

kkrumm1 commented Oct 5, 2017

testing meow...

@murrant what do you want to report back the discovery protocols debug?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 5, 2017

Member

@kkrumm1 see if you still get the eventlog entries with the odd hostnames.

Member

laf commented Oct 5, 2017

@kkrumm1 see if you still get the eventlog entries with the odd hostnames.

@kkrumm1

This comment has been minimized.

Show comment
Hide comment
@kkrumm1

kkrumm1 Oct 5, 2017

Member

looks like they are still showing up [cdpCacheDeviceId] => H..B.t
[cdpCacheDevicePort] => H..B.t

https://pastebin.com/EtdNfjJC

Member

kkrumm1 commented Oct 5, 2017

looks like they are still showing up [cdpCacheDeviceId] => H..B.t
[cdpCacheDevicePort] => H..B.t

https://pastebin.com/EtdNfjJC

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 5, 2017

Member

@kkrumm1 yes, that is the output from your device. You have some device inserting odd info into lldp.
This fixes the attempt to add the device with an obviously bad hostname.

Member

murrant commented Oct 5, 2017

@kkrumm1 yes, that is the output from your device. You have some device inserting odd info into lldp.
This fixes the attempt to add the device with an obviously bad hostname.

@laf

laf approved these changes Oct 5, 2017

@murrant murrant merged commit a2b9342 into librenms:master Oct 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:valid-hostname branch Oct 5, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.