New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPE ILO4 enhance #7436

Merged
merged 12 commits into from Oct 9, 2017

Conversation

Projects
None yet
3 participants
@TomEvin
Contributor

TomEvin commented Oct 5, 2017

Added Storage, Memory pools, new status (Array Controller, Logical Drive)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

TomEvin added some commits Oct 5, 2017

HPE ILO4 enhance
Added Storage, Memory pools, new status (Array Controller, Logical Drive)
@laf

Some comments left in the code.

Show outdated Hide outdated includes/discovery/mempools/hpe-ilo.inc.php Outdated
Show outdated Hide outdated includes/discovery/mempools/hpe-ilo.inc.php Outdated
Show outdated Hide outdated includes/discovery/storage/hpe-ilo.inc.php Outdated
Show outdated Hide outdated includes/discovery/storage/hpe-ilo.inc.php Outdated
Show outdated Hide outdated includes/polling/mempools/hpe-ilo.inc.php Outdated
Show outdated Hide outdated includes/polling/mempools/hpe-ilo.inc.php Outdated
Show outdated Hide outdated includes/polling/mempools/hpe-ilo.inc.php Outdated
Show outdated Hide outdated includes/polling/storage/hpe.ilo.inc.php Outdated
Show outdated Hide outdated includes/polling/storage/hpe.ilo.inc.php Outdated
Show outdated Hide outdated includes/polling/storage/hpe.ilo.inc.php Outdated

TomEvin added some commits Oct 9, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 9, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Oct 9, 2017

The inspection completed: No new issues

@TomEvin

This comment has been minimized.

Show comment
Hide comment
@TomEvin

TomEvin Oct 9, 2017

Contributor

@laf I have made changes based on your comments. I hope this is what you mean, and now it is fit for the rest of the Libre. Let me know if I have to change or test anything else.

Contributor

TomEvin commented Oct 9, 2017

@laf I have made changes based on your comments. I hope this is what you mean, and now it is fit for the rest of the Libre. Let me know if I have to change or test anything else.

@laf

laf approved these changes Oct 9, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 9, 2017

Member

👍 Thanks @TomEvin

image

Member

laf commented Oct 9, 2017

👍 Thanks @TomEvin

image

@laf laf merged commit c8b6777 into librenms:master Oct 9, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.