New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for ApsoluteOS / Defense Pro Hw #7440

Merged
merged 17 commits into from Oct 10, 2017

Conversation

Projects
None yet
3 participants
@sfini
Contributor

sfini commented Oct 6, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

sfini added some commits Oct 6, 2017

@laf

Thanks for the PR.

Most of these mibs look like they are ones we have already. Please remove all the duplicates and put the needed ones into a radware folder.

type: network
icon: radware
group: radware
mib_dir:

This comment has been minimized.

@laf

laf Oct 6, 2017

Member

You should just put the mibs you need in to a directory called mibs/radware

@laf

laf Oct 6, 2017

Member

You should just put the mibs you need in to a directory called mibs/radware

This comment has been minimized.

@sfini

sfini Oct 9, 2017

Contributor

@laf
Done

@sfini

sfini Oct 9, 2017

Contributor

@laf
Done

Show outdated Hide outdated includes/definitions/discovery/apsoluteos.yaml
Show outdated Hide outdated includes/polling/os/apsoluteos.inc.php
Show outdated Hide outdated includes/polling/os/apsoluteos.inc.php

sfini added some commits Oct 9, 2017

@sfini

This comment has been minimized.

Show comment
Hide comment
@sfini

sfini Oct 9, 2017

Contributor

@laf
All changes done

Contributor

sfini commented Oct 9, 2017

@laf
All changes done

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 9, 2017

Member

So it's mainly the mibs now, you've got a folder called mibs/defense_pro/ this contains a lot of existing MIBs so you can remove those - you should just put what you need in the radware folder anyway.

Member

laf commented Oct 9, 2017

So it's mainly the mibs now, you've got a folder called mibs/defense_pro/ this contains a lot of existing MIBs so you can remove those - you should just put what you need in the radware folder anyway.

@sfini

This comment has been minimized.

Show comment
Hide comment
@sfini

sfini Oct 9, 2017

Contributor

@laf
😂 i've forgot to delete it 😂

Contributor

sfini commented Oct 9, 2017

@laf
😂 i've forgot to delete it 😂

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 9, 2017

Member

It's not just that one, you've got over 90 files which most look like duplicates.

Member

laf commented Oct 9, 2017

It's not just that one, you've got over 90 files which most look like duplicates.

@sfini

This comment has been minimized.

Show comment
Hide comment
@sfini

sfini Oct 9, 2017

Contributor

Yes... I'm looking how can i delete entire directory... Any help ?

Contributor

sfini commented Oct 9, 2017

Yes... I'm looking how can i delete entire directory... Any help ?

delete mib dir
delete
@sfini

This comment has been minimized.

Show comment
Hide comment
@sfini

sfini Oct 9, 2017

Contributor

@laf
Delete defense_pro dir done

Contributor

sfini commented Oct 9, 2017

@laf
Delete defense_pro dir done

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 10, 2017

Member

Ok one last thing (couldn't see it before due to the large volume of files);

git mv mibs/radware/radwaremib.txt mibs/radware/RADWARE-MIB

The mib needs to be named correctly, that above command will fix it.

Member

laf commented Oct 10, 2017

Ok one last thing (couldn't see it before due to the large volume of files);

git mv mibs/radware/radwaremib.txt mibs/radware/RADWARE-MIB

The mib needs to be named correctly, that above command will fix it.

@sfini

This comment has been minimized.

Show comment
Hide comment
@sfini

sfini Oct 10, 2017

Contributor

@laf
This is the original file name . I have pushed the original file downloaded from radware support .

Contributor

sfini commented Oct 10, 2017

@laf
This is the original file name . I have pushed the original file downloaded from radware support .

@sfini

This comment has been minimized.

Show comment
Hide comment
@sfini

sfini Oct 10, 2017

Contributor

@laf
Change name done

Contributor

sfini commented Oct 10, 2017

@laf
Change name done

@laf

laf approved these changes Oct 10, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 10, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Oct 10, 2017

The inspection completed: No new issues

@laf laf merged commit 3381b40 into librenms:master Oct 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@sfini sfini deleted the sfini:patch-6 branch Oct 10, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.