New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVICE: zyxelnwa, add storage, mempools and wireless #7441

Merged
merged 5 commits into from Oct 7, 2017

Conversation

Projects
None yet
3 participants
@tomarch
Contributor

tomarch commented Oct 6, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Show outdated Hide outdated includes/polling/os/zyxelnwa.inc.php
Show outdated Hide outdated includes/polling/os/zyxelnwa.inc.php
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 7, 2017

Member

Thanks @tomarch. the only last thing, sorry to be a pain is to rename the MIBs. The filenames should be that of the actual MIB name to make it easier to find. I.e: mibs/zyxelnwa/ZYXEL-ES-COMMON.MIB should be mibs/zyxelnwa/ZYXEL-ES-COMMON. The name is from the line: ZYXEL-ES-COMMON DEFINITIONS ::= BEGIN (line 13) of the mib.

Member

laf commented Oct 7, 2017

Thanks @tomarch. the only last thing, sorry to be a pain is to rename the MIBs. The filenames should be that of the actual MIB name to make it easier to find. I.e: mibs/zyxelnwa/ZYXEL-ES-COMMON.MIB should be mibs/zyxelnwa/ZYXEL-ES-COMMON. The name is from the line: ZYXEL-ES-COMMON DEFINITIONS ::= BEGIN (line 13) of the mib.

@tomarch

This comment has been minimized.

Show comment
Hide comment
@tomarch

tomarch Oct 7, 2017

Contributor

No problem ;)

Contributor

tomarch commented Oct 7, 2017

No problem ;)

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 7, 2017

The inspection completed: 2 updated code elements

scrutinizer-notifier commented Oct 7, 2017

The inspection completed: 2 updated code elements

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 7, 2017

Member

image

Member

laf commented Oct 7, 2017

image

@laf laf merged commit c927e6d into librenms:master Oct 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.