New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Configurable 95th percentile #7442

Merged
merged 1 commit into from Oct 11, 2017

Conversation

Projects
None yet
5 participants
@yunchih
Contributor

yunchih commented Oct 6, 2017

See issue #7406 for detail. I have run the lint check, but is still not sure if the code is of standard.

Please help review. Thanks.


DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Oct 6, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Oct 6, 2017

CLA assistant check
All committers have signed the CLA.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 6, 2017

Member

All good from me with one small exception. As the config $config['rrdgraph_real_95th'] has been changed to $config['rrdgraph_real_percentile'] then we should maintain backwards compatibility by adding something like:

if ($config['rrdgraph_real_95th']) {
    $config['rrdgraph_real_percentile'] = $config['rrdgraph_real_95th'];
}

To the end of: includes/process_config.inc.php

After that, 👍

Member

laf commented Oct 6, 2017

All good from me with one small exception. As the config $config['rrdgraph_real_95th'] has been changed to $config['rrdgraph_real_percentile'] then we should maintain backwards compatibility by adding something like:

if ($config['rrdgraph_real_95th']) {
    $config['rrdgraph_real_percentile'] = $config['rrdgraph_real_95th'];
}

To the end of: includes/process_config.inc.php

After that, 👍

feature: Configurable 95th percentile
See issue #7406 for detail.
@yunchih

This comment has been minimized.

Show comment
Hide comment
@yunchih

yunchih Oct 7, 2017

Contributor

Thanks, @laf , I have updated as requested.

Contributor

yunchih commented Oct 7, 2017

Thanks, @laf , I have updated as requested.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 7, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Oct 7, 2017

The inspection completed: No new issues

@laf

laf approved these changes Oct 7, 2017

LGTM - Thanks for the PR

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 11, 2017

Member

Well, I was going to say something about the config name being changed for rrdgraph_real_95th, but I tested rrdgraph_real_95th and it didn't seem to be any different because max seems to calculated per period and we only have one value per 5 minutes.

So, LGTM.

Member

murrant commented Oct 11, 2017

Well, I was going to say something about the config name being changed for rrdgraph_real_95th, but I tested rrdgraph_real_95th and it didn't seem to be any different because max seems to calculated per period and we only have one value per 5 minutes.

So, LGTM.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 11, 2017

Member

@yunchih just need you to sign the CLA please.

Member

laf commented Oct 11, 2017

@yunchih just need you to sign the CLA please.

@yunchih

This comment has been minimized.

Show comment
Hide comment
@yunchih

yunchih Oct 11, 2017

Contributor

@laf Thanks! Done.

Contributor

yunchih commented Oct 11, 2017

@laf Thanks! Done.

@laf laf merged commit 82fb20c into librenms:master Oct 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 11, 2017

Member

image

Member

laf commented Oct 11, 2017

image

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.