New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed clickatell alert transport #7446

Merged
merged 4 commits into from Oct 16, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Oct 7, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #7374

Not sure how this was supposed to work before, variables that we hadn't documented or were available in the webui were expected. Update based on code from that issue + reference from https://www.clickatell.com/developers/api-documentation/http-api-send-message/

@Rosiak

Rosiak approved these changes Oct 9, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 9, 2017

Member

Small update. Removed from as we don't have support for setting that.

Also updated two config columns to resolve this not working in strict mode.

Member

laf commented Oct 9, 2017

Small update. Removed from as we don't have support for setting that.

Also updated two config columns to resolve this not working in strict mode.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 11, 2017

Member

Looks good to merge after fixing db_schema.yaml

I can't test it of course.

Member

murrant commented Oct 11, 2017

Looks good to merge after fixing db_schema.yaml

I can't test it of course.

laf added some commits Oct 15, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 15, 2017

Member

Fixed db_schema

Member

laf commented Oct 15, 2017

Fixed db_schema

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 15, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Oct 15, 2017

The inspection completed: No new issues

@murrant murrant merged commit 9774acd into librenms:master Oct 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

laf added a commit that referenced this pull request Oct 16, 2017

laf added a commit that referenced this pull request Oct 16, 2017

Revert "bug: fail isPingable if fping errors" (#7496)
* Revert "fix: Fixed clickatell alert transport (#7446)"

This reverts commit 9774acd.

* Revert "newdevice: Added support for Eaton ATS devices (#7448)"

This reverts commit 1318e58.

* Revert "newdevice: Updated Zhone MXK detection (#7488)"

This reverts commit 81667b9.

* Revert "docs: Added HipChat V2 WebUI Config Example (#7486)"

This reverts commit a31eaa9.

* Revert "fix: Fail isPingable if fping errors (#7426)"

This reverts commit 1998845.

@laf laf deleted the laf:fix/issue-7374 branch Oct 16, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.