New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Updated Cisco WAP detection and merged in ciscosmblinux OS #7447

Merged
merged 2 commits into from Oct 27, 2017

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Oct 8, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Do not merge yet.

Fixes: #7402

This gets rid of what looks like a duplicate OS so we will need to do a notification first.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 9, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Oct 9, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 15, 2017

Member

Any comments?

Member

laf commented Oct 15, 2017

Any comments?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 20, 2017

Member

Go ahead and remove the duplicate.

Member

murrant commented Oct 20, 2017

Go ahead and remove the duplicate.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 21, 2017

Member

Notification done. Needs merging on the 27th of October.

Member

laf commented Oct 21, 2017

Notification done. Needs merging on the 27th of October.

@laf laf merged commit 65b0c8b into librenms:master Oct 27, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:newdevice/issue-7402 branch Oct 27, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.