New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: EATON-ATS #7448

Merged
merged 8 commits into from Oct 15, 2017

Conversation

Projects
None yet
3 participants
@tomarch
Contributor

tomarch commented Oct 9, 2017

add definition, voltage, frequency and state

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 9, 2017

Member

Thanks @tomarch

The sensors look like they could be done from yaml, have you tried that? Need any help in doing that?

Member

laf commented Oct 9, 2017

Thanks @tomarch

The sensors look like they could be done from yaml, have you tried that? Need any help in doing that?

Show outdated Hide outdated includes/definitions/eaton-ats.yaml Outdated
@tomarch

This comment has been minimized.

Show comment
Hide comment
@tomarch

tomarch Oct 9, 2017

Contributor

I haven't try with yaml. I will take a look. Is there any performance difference between php?

Contributor

tomarch commented Oct 9, 2017

I haven't try with yaml. I will take a look. Is there any performance difference between php?

Show outdated Hide outdated includes/definitions/eaton-ats.yaml Outdated
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 9, 2017

Member

No performance difference but all discovery is being moved to yaml so if it's possible to do it in that (which it appears to) then we won't accept the php side of it.

Member

laf commented Oct 9, 2017

No performance difference but all discovery is being moved to yaml so if it's possible to do it in that (which it appears to) then we won't accept the php side of it.

@tomarch

This comment has been minimized.

Show comment
Hide comment
@tomarch

tomarch Oct 10, 2017

Contributor

Ok, i've try with yaml but it can't work. The index return by the device is a string ("source1" and "source2"), so i can't have a numerical OID :
NMP[/usr/bin/snmpget -v1 -c COMMUNITY -OUQnt -M /opt/librenms/mibs:/opt/librenms/mibs/eaton udp:HOSTNAME:161 .1.3.6.1.4.1.534.10.2.2.2.1.2.source1 .1.3.6.1.4.1.534.10.2.2.2.1.2.source2 .1.3.6.1.4.1.2682.2.2.3.1.00]
.1.3.6.1.4.1.534.10.2.2.2.1.2.source1: Unknown Object Identifier (Sub-id not found: enterprises -> source1)
.1.3.6.1.4.1.534.10.2.2.2.1.2.source2: Unknown Object Identifier (Sub-id not found: enterprises -> source2)

Unless there's a trick to obtain numerical index with yaml syntax, we need php file.

Contributor

tomarch commented Oct 10, 2017

Ok, i've try with yaml but it can't work. The index return by the device is a string ("source1" and "source2"), so i can't have a numerical OID :
NMP[/usr/bin/snmpget -v1 -c COMMUNITY -OUQnt -M /opt/librenms/mibs:/opt/librenms/mibs/eaton udp:HOSTNAME:161 .1.3.6.1.4.1.534.10.2.2.2.1.2.source1 .1.3.6.1.4.1.534.10.2.2.2.1.2.source2 .1.3.6.1.4.1.2682.2.2.3.1.00]
.1.3.6.1.4.1.534.10.2.2.2.1.2.source1: Unknown Object Identifier (Sub-id not found: enterprises -> source1)
.1.3.6.1.4.1.534.10.2.2.2.1.2.source2: Unknown Object Identifier (Sub-id not found: enterprises -> source2)

Unless there's a trick to obtain numerical index with yaml syntax, we need php file.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 11, 2017

Member

It will be easier if you pastebin your yaml, we can then advise.

Member

laf commented Oct 11, 2017

It will be easier if you pastebin your yaml, we can then advise.

@tomarch

This comment has been minimized.

Show comment
Hide comment
@tomarch
Contributor

tomarch commented Oct 11, 2017

tomarch and others added some commits Oct 11, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 15, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Oct 15, 2017

The inspection completed: No new issues

@laf laf merged commit 1318e58 into librenms:master Oct 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

laf added a commit that referenced this pull request Oct 16, 2017

laf added a commit that referenced this pull request Oct 16, 2017

Revert "bug: fail isPingable if fping errors" (#7496)
* Revert "fix: Fixed clickatell alert transport (#7446)"

This reverts commit 9774acd.

* Revert "newdevice: Added support for Eaton ATS devices (#7448)"

This reverts commit 1318e58.

* Revert "newdevice: Updated Zhone MXK detection (#7488)"

This reverts commit 81667b9.

* Revert "docs: Added HipChat V2 WebUI Config Example (#7486)"

This reverts commit a31eaa9.

* Revert "fix: Fail isPingable if fping errors (#7426)"

This reverts commit 1998845.
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.