New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New os ray #7466

Merged
merged 2 commits into from Oct 15, 2017

Conversation

Projects
None yet
4 participants
@erotel
Contributor

erotel commented Oct 10, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 11, 2017

Member

Thanks for the PR.

The two sensors need to be moved to yaml (see our docs). If you need help with this then let me know.

Member

laf commented Oct 11, 2017

Thanks for the PR.

The two sensors need to be moved to yaml (see our docs). If you need help with this then let me know.

@erotel

This comment has been minimized.

Show comment
Hide comment
@erotel

erotel Oct 11, 2017

Contributor

Move sensor to yaml not work.

Contributor

erotel commented Oct 11, 2017

Move sensor to yaml not work.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 11, 2017

Member

Why?

Member

laf commented Oct 11, 2017

Why?

@erotel

This comment has been minimized.

Show comment
Hide comment
@erotel

erotel Oct 11, 2017

Contributor

Ray have broken snmp.Not return oid index. return etc. sysuptime =X not sysuptime.0 = X.

Contributor

erotel commented Oct 11, 2017

Ray have broken snmp.Not return oid index. return etc. sysuptime =X not sysuptime.0 = X.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 11, 2017

Member

At some stage we won't be using php to do discovery so you will need to raise this to the vendor to get fixed,

Member

laf commented Oct 11, 2017

At some stage we won't be using php to do discovery so you will need to raise this to the vendor to get fixed,

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 11, 2017

The inspection completed: 5 updated code elements

scrutinizer-notifier commented Oct 11, 2017

The inspection completed: 5 updated code elements

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 13, 2017

Member

@erotel laf means the temperature and voltage sensors.

Member

murrant commented Oct 13, 2017

@erotel laf means the temperature and voltage sensors.

@laf laf merged commit f48cff0 into librenms:master Oct 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.